Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subversion failes with "option ':command' is not a valid option for Mixlib::ShellOut" #2634

Merged
merged 1 commit into from
Dec 15, 2014

Conversation

BackSlasher
Copy link
Contributor

Improper use of shell_out!, which uses Mixlib
Fixed #2633

@BackSlasher
Copy link
Contributor Author

I think the Travis CI is a bit bonkers.
The failures don't seem related to my modifications

@BackSlasher
Copy link
Contributor Author

My bad, I'm checking it.
Trying to figure out rspec.

…ixlib::ShellOut"

Improper use of `shell_out!`, which uses Mixlib
Fixed chef#2633
@lamont-granquist
Copy link
Contributor

yeah not sure if i just had derp that day or missed a commit or something, but this LGTM

👍

@sersut
Copy link
Contributor

sersut commented Dec 15, 2014

👍

@sersut sersut added the Bug label Dec 15, 2014
@sersut sersut self-assigned this Dec 15, 2014
sersut pushed a commit that referenced this pull request Dec 15, 2014
Subversion failes with "option ':command' is not a valid option for Mixlib::ShellOut"
@sersut sersut merged commit b4abc3f into chef:master Dec 15, 2014
sersut pushed a commit that referenced this pull request Dec 15, 2014
Subversion failes with "option ':command' is not a valid option for Mixlib::ShellOut"
sersut pushed a commit that referenced this pull request Dec 15, 2014
Merge pull request #2634 from BackSlasher/repair-subversion-command
sersut pushed a commit that referenced this pull request Dec 15, 2014
sersut pushed a commit that referenced this pull request Dec 15, 2014
sersut pushed a commit that referenced this pull request Dec 15, 2014
@BackSlasher BackSlasher deleted the repair-subversion-command branch December 16, 2014 05:51
@BackSlasher BackSlasher restored the repair-subversion-command branch January 1, 2015 13:14
@BackSlasher BackSlasher deleted the repair-subversion-command branch January 1, 2015 13:15
jaym added a commit that referenced this pull request Feb 19, 2015
* origin/12-stable: (83 commits)
  Disable win32 memory leak tests
  Stub windows? check in the unit test to make sure specs are green on windows.
  Fix build version for appveyor to be specific to the 12-stable branch
  More info more version
  Adding appveyor.yml
  Merge pull request #2749 from opscode/jdm/metadata-error-info
  Clearing out DOC_CHANGES from 12-stable because all docs have been updated since 12.0.3 release
  Contribution info for #2658.
  Bump version for 12.0.3 release.
  Merge pull request #2594 from jaymzh/digester
  Bump version number for 12.0.2 release.
  add CHANGELOG.md
  fix apt default_release attribute broken in 12.0
  Merge pull request #2650 from opscode/sersut/contrib-json
  Merge pull request #2642 from opscode/btm/site_install_json
  Changelog for #2621
  Merge pull request #2645 from opscode/sersut/contrib-2634
  Merge pull request #2634 from BackSlasher/repair-subversion-command
  Fixing homebrew package to use provider resolver per code review
  Update CHANGELOG for #2630
  ...

Conflicts:
	.travis.yml
	CHANGELOG.md
	DOC_CHANGES.md
	appveyor.yml
	lib/chef/application.rb
	lib/chef/dsl/recipe.rb
	lib/chef/knife/bootstrap.rb
	lib/chef/knife/core/bootstrap_context.rb
	lib/chef/node/attribute.rb
	lib/chef/node/attribute_collections.rb
	lib/chef/node/immutable_collections.rb
	lib/chef/resource.rb
	lib/chef/run_context.rb
	lib/chef/version.rb
	spec/functional/dsl/reboot_pending_spec.rb
	spec/functional/event_loggers/windows_eventlog_spec.rb
	spec/functional/resource/link_spec.rb
	spec/support/platform_helpers.rb
	spec/unit/knife_spec.rb
	spec/unit/mixin/deep_merge_spec.rb
	spec/unit/mixin/shell_out_spec.rb
	spec/unit/node/attribute_spec.rb
	spec/unit/node_spec.rb
	spec/unit/provider/package/apt_spec.rb
	spec/unit/provider/service/systemd_service_spec.rb
	spec/unit/provider_resolver_spec.rb
	spec/unit/recipe_spec.rb
	spec/unit/resource/resource_notification_spec.rb
	spec/unit/run_context_spec.rb
@chef-supermarket chef-supermarket assigned ksubrama and unassigned sersut May 26, 2016
@thommay thommay added Type: Bug Does not work as expected. Status: Ready for Merge and removed Bug labels Jan 25, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subversion fails with "option ':command' is not a valid option for Mixlib::ShellOut"
6 participants