Improve Error Messages for SSL Errors in Knife #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As Jay pointed out in another PR, the end-to-end tests are failing b/c of a change in a cookbook that's not locked down. |
|
Jay explains the failing e2e tests here: #2629 (comment) |
danielsdeleo
force-pushed
the
knife-ssl-error-messaging
branch
from
2edc64d
to
6aef547
Compare
|
👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 |
|
👍 |
|
|
Knife now gives an error message like this when an SSL error occurs: ``` ERROR: Could not establish a secure connection to the server. Use `knife ssl check` to troubleshoot your SSL configuration. If your Chef Server uses a self-signed certificate, you can use `knife ssl fetch` to make knife trust the server's certificates. Original Exception: OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed ```
danielsdeleo
force-pushed
the
knife-ssl-error-messaging
branch
from
6aef547
to
49689f6
Compare
danielsdeleo
added a commit
that referenced
this pull request
Dec 15, 2014
jaym
added a commit
that referenced
this pull request
Feb 19, 2015
* origin/12-stable: (83 commits) Disable win32 memory leak tests Stub windows? check in the unit test to make sure specs are green on windows. Fix build version for appveyor to be specific to the 12-stable branch More info more version Adding appveyor.yml Merge pull request #2749 from opscode/jdm/metadata-error-info Clearing out DOC_CHANGES from 12-stable because all docs have been updated since 12.0.3 release Contribution info for #2658. Bump version for 12.0.3 release. Merge pull request #2594 from jaymzh/digester Bump version number for 12.0.2 release. add CHANGELOG.md fix apt default_release attribute broken in 12.0 Merge pull request #2650 from opscode/sersut/contrib-json Merge pull request #2642 from opscode/btm/site_install_json Changelog for #2621 Merge pull request #2645 from opscode/sersut/contrib-2634 Merge pull request #2634 from BackSlasher/repair-subversion-command Fixing homebrew package to use provider resolver per code review Update CHANGELOG for #2630 ... Conflicts: .travis.yml CHANGELOG.md DOC_CHANGES.md appveyor.yml lib/chef/application.rb lib/chef/dsl/recipe.rb lib/chef/knife/bootstrap.rb lib/chef/knife/core/bootstrap_context.rb lib/chef/node/attribute.rb lib/chef/node/attribute_collections.rb lib/chef/node/immutable_collections.rb lib/chef/resource.rb lib/chef/run_context.rb lib/chef/version.rb spec/functional/dsl/reboot_pending_spec.rb spec/functional/event_loggers/windows_eventlog_spec.rb spec/functional/resource/link_spec.rb spec/support/platform_helpers.rb spec/unit/knife_spec.rb spec/unit/mixin/deep_merge_spec.rb spec/unit/mixin/shell_out_spec.rb spec/unit/node/attribute_spec.rb spec/unit/node_spec.rb spec/unit/provider/package/apt_spec.rb spec/unit/provider/service/systemd_service_spec.rb spec/unit/provider_resolver_spec.rb spec/unit/recipe_spec.rb spec/unit/resource/resource_notification_spec.rb spec/unit/run_context_spec.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a case for SSL errors to
knife's error handling, which points users to theknife ssl checkandknife ssl fetchcommands.@opscode/client-core @opscode/client-engineers