allow setting of deb/rpm/solaris user and group ownership for package files #80
Conversation
|
This LGTM, @lamont-granquist any objections? |
|
i ripped fpm out of solaris, so i'm pretty sure that won't work... would need to be ported to solaris/aix/sh to fully support it... i don't think we need to block on that for accepting it though... |
@lamont-granquist Can you expand on what you mean by this? |
|
fpm was broken on solaris (pretty horribly, with postinstall scripts not getting bundled with the software so that 11.6.0 was unusable on solaris), so omnibus-ruby just directly uses pkgmk now. |
|
fpm issue is still open: jordansissel/fpm#551 if you want to tackle that, it could get patched and better maintained 'upstream' and then we could revert those changes and go back to using fpm.... as a result of all those issues we do have functional tests now in omnibus-chef's client-test and install-test scripts that make sure that the postinstall / postremove scripts are present and correctly setup symlinks... fpm is not very well-maintained on solaris, though, so i viewed it as something that was going to get lost in the 87 other issues that project has open on it, and likely to break in the future, while our use of pkgmk is really not that complicated, and i wanted something that wasn't going to get broken because someone refactored how debs and/or rpms got built and that broke solaris again... |
|
@lamont-granquist Roger. Thanks for the background! |
allow setting of deb/rpm/solaris user and group ownership for package files
FPM uses whatever user it's run as by default. If you'd like me to set "root" as default I can update PR.