XCode bitcode issue #300
Merged
XCode bitcode issue #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
suggested changes
Aug 24, 2018
| @@ -1892,6 +1892,7 @@ | |||
| isa = XCBuildConfiguration; | |||
| buildSettings = { | |||
| ALWAYS_SEARCH_USER_PATHS = NO; | |||
| BITCODE_GENERATION_MODE = marker; | |||
There was a problem hiding this comment.
shouldn't this be embed?
There was a problem hiding this comment.
This is for debug build which should use "fembed-bitcode-marker" flag while compiling.
There was a problem hiding this comment.
does, it automatically add embed because it isn't in the project file at all?
There was a problem hiding this comment.
Yes. If you set BITCODE_GENERATION_MODE=marker, the files will be compiled using the flag -fembed-bitcode-marker
* master: this runs through the background and removes any experiments that are… (#302) Updating libraries based on SourceClear recommendation (#304) add credits for third party libraries (#299) # Conflicts: # OptimizelySDKUniversal/generated-frameworks/Release-iOS-universal-SDK/OptimizelySDKiOS.framework.zip # OptimizelySDKUniversal/generated-frameworks/Release-iOS-universal-SDK/OptimizelySDKiOS.framework/OptimizelySDKiOS
thomaszurkan-optimizely
approved these changes
Sep 21, 2018
AbdurRafay
pushed a commit
that referenced
this pull request
Sep 24, 2018
* master: refactor(EventBuilder): Moved decision service and bucketing from EventBuilder to Optimizely (#306) fix(datafile-parsing): Prevent SDK from initializing if the datafile … (#305) XCode bitcode issue (#300) Add missing nullable and nonnull annotations. Only log attribute not found if it is not found (#311) # Conflicts: # OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.h # OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.m # OptimizelySDKCore/OptimizelySDKCoreTests/OPTLYEventBuilderTest.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.