Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating libraries based on SourceClear recommendation #304

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an easy approve because the changes are only for the XCTests

@aliabbasrizvi
Copy link
Contributor Author

Checked with @mikeng13 . Compat suite setup is having some issues. I have relaxed it from being a requirement for the time being.

@aliabbasrizvi aliabbasrizvi merged commit d962ac5 into master Aug 31, 2018
@aliabbasrizvi aliabbasrizvi deleted the ali/update_librar branch August 31, 2018 18:10
AbdurRafay pushed a commit that referenced this pull request Sep 3, 2018
* master:
  Updating libraries based on SourceClear recommendation (#304)
AbdurRafay pushed a commit that referenced this pull request Sep 10, 2018
* master:
  this runs through the background and removes any experiments that are… (#302)
  Updating libraries based on SourceClear recommendation (#304)
  add credits for third party libraries (#299)

# Conflicts:
#	OptimizelySDKUniversal/generated-frameworks/Release-iOS-universal-SDK/OptimizelySDKiOS.framework.zip
#	OptimizelySDKUniversal/generated-frameworks/Release-iOS-universal-SDK/OptimizelySDKiOS.framework/OptimizelySDKiOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants