feat(api): Accepting all types for attributes values #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
requested review from
thomaszurkan-optimizely and
mikeproeng37
msohailhussain
changed the title
* master: refactor(EventBuilder): Moved decision service and bucketing from EventBuilder to Optimizely (#306) fix(datafile-parsing): Prevent SDK from initializing if the datafile … (#305) XCode bitcode issue (#300) Add missing nullable and nonnull annotations. Only log attribute not found if it is not found (#311) # Conflicts: # OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.h # OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.m # OptimizelySDKCore/OptimizelySDKCoreTests/OPTLYEventBuilderTest.m
|
build |
* master: update changelog for new release (#322) add test script and fix broken carthage build (#321) Prepare for2.1.1 (#318) add EventTagUtil to universal project (#314) Fix an issue where importing an Objective-C type called Optional causes LLDB to sometimes not be able to distinguish between Swift.Optional and OptimizelySDKiOS.Optional. (#274) remove unused protocol (#313) fix(whitelisting): Invalid whitelisted variation stops bucketing (#308)
msohailhussain
changed the title
|
build |
thomaszurkan-optimizely
suggested changes
Oct 9, 2018
…t all type of attributes. One more unit test fixed. For NSNull and Any object other than NSNumber.
|
@mikeng13 Can you merge this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To support all types of attribute values I changed all relevant function signatures from NSDictionary<NSString *, NSString *> to NSDictionary<NSString *, NSObject *> so that it can accepts an Object variable rather than just a String for functions that accept and uses attributes.
Testing
All types of attributes are added in Optimizely and EventBuilder test cases and they are passing.