fix json model problems so that you can access objects correctly #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
requested review from
mikeproeng37 and
msohailhussain
|
|
||
| if let experiments = optimizelyClient?.optimizely?.config?.experiments { | ||
| for experiment in experiments { | ||
| print(experiment.experimentKey) |
There was a problem hiding this comment.
Print? Is this desired?
There was a problem hiding this comment.
it's the demo app. this is just proving that the change works.
thomaszurkan-optimizely
added a commit
that referenced
this pull request
Nov 8, 2018
* fix json model problems so that you can access objects correctly * use the project config to correctly get experiments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the issue with Swift 4.2 accessing the entities in a data model and having to cast them because the protocol is not actually defined.
The problem is that these were not implemented correctly to start with. The entities should be what an array should contain. The protocols are just notations for JSONModel (OPTLYJSONModel). So, for example:
The above old implementation defines a array of OPTLYExperiment protocol objects. However, the OPTLYExperiment contains no methods or properties. The proper declaring is the following:
This seems to be a JSONModel specific annotation via the protocols at the end.
**We should do this for all data model objects using arrays of protocols.