Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Empty UserId (Activate and Track) #356

Merged
merged 4 commits into from
Jan 11, 2019
Merged

Support for Empty UserId (Activate and Track) #356

merged 4 commits into from
Jan 11, 2019

Conversation

yasirfolio3
Copy link
Contributor

Added support in track and activate calls to accept empty user id as valid.

@yasirfolio3 yasirfolio3 changed the title Support for Empty User Id (Activate and Track) Support for Empty UserId (Activate and Track) Jan 10, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+17.4%) to 97.899% when pulling 882b2cc on yasir/empty-userid-support into db72170 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+17.4%) to 97.899% when pulling 882b2cc on yasir/empty-userid-support into db72170 on master.

@coveralls
Copy link

coveralls commented Jan 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 97.904% when pulling 11f460e on yasir/empty-userid-support into 7003a14 on master.

@msohailhussain msohailhussain requested a review from a team January 10, 2019 18:21
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 925850a into master Jan 11, 2019
@yasirfolio3 yasirfolio3 deleted the yasir/empty-userid-support branch January 17, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasirfolio3 @coveralls @thomaszurkan-optimizely