Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9563] [React] Fix onready segments #206

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

rafinutshaw-optimizely
Copy link
Contributor

Summary

  • OnReady should only fetchqualifiedsegments if user is ready
  • Setuser should only fetchqualified segments if js-client is ready

Test plan

  • Current test cases should pass

Issues

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good catch! A couple of clarifications.

src/client.ts Show resolved Hide resolved
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafinutshaw-optimizely rafinutshaw-optimizely merged commit 2bba887 into master Aug 4, 2023
@rafinutshaw-optimizely rafinutshaw-optimizely deleted the utshaw/fix-onready-segments branch August 4, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants