[FSSDK-9654] fix: Default to VUID without user(id) as Provider prop #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll re-open later when I've more progress. |
It really is needed so that vuid in JS SDK is ready
|
I think I'm actually ready for a review of this @raju-opti and @jaeopt. Sorry, this took so long to untangle this new anon paradigm using vuid. |
|
Developer review completed. |
|
I have an e2e test config set up and able to demo effect. |
jaeopt
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Thanks @jaeopt . I've replied to your comments.
@raju-opti I'd love your double sign off too on this PR.
fabb
reviewed
Jan 26, 2024
| const { optimizely, userId, userAttributes, user } = props; | ||
| } | ||
|
|
||
| componentDidMount(): void { |
There was a problem hiding this comment.
this introduces a bug and breaks SSR:
#234
There was a problem hiding this comment.
Internal ticket opened and put into this sprint.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OptimizelyProvideris used without theuser?oruserId?props, we should retrieve and use the VUID foroptimizely.setUser()constructor()of provider into lifecycle methodcomponentDidMount()getVuid()Test plan
Issues