feat: Added getFeatureVariableJson, getFeatureVariable and getAllFeatureVariables #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
previously requested changes
Jul 7, 2020
mjc1283
approved these changes
Jul 8, 2020
README.md
Outdated
| @@ -484,7 +484,7 @@ The following type definitions are used in the `ReactSDKClient` interface: | |||
| - `onUserUpdate(handler: (userInfo: User) => void): () => void` Subscribe a callback to be called when this instance's current user changes. Returns a function that will unsubscribe the callback. | |||
| - `activate(experimentKey: string, overrideUserId?: string, overrideAttributes?: UserAttributes): string | null` Activate an experiment, and return the variation for the given user. | |||
| - `getVariation(experimentKey: string, overrideUserId?: string, overrideAttributes?: UserAttributes): string | null` Return the variation for the given experiment and user. | |||
| - `getFeatureVariables(featureKey: string, overrideUserId?: string, overrideAttributes?: UserAttributes): VariableValuesObject`: Decide and return variable values for the given feature and user | |||
| - `getFeatureVariables(featureKey: string, overrideUserId?: string, overrideAttributes?: UserAttributes): VariableValuesObject`: Decide and return variable values for the given feature and user <br /> <b>Warning:</b> Deprecated since 2.0.1 <br /> `getAllFeatureVariables` is added in JavaScript SDK which is similarly returning all the feature variables, but it sends only single notification of type `all-feature-variables` instead of sending for each variable. As `getFeatureVariables` was added when this functionality wasn't provided by `JavaScript SDK`, so there is no need of it now and it would be removed in next major release | |||
There was a problem hiding this comment.
I think it should be Deprecated since 2.1.0. This release will be 2.1.0.
| @@ -38,6 +38,9 @@ describe('ReactSDKClient', () => { | |||
| getForcedVariation: jest.fn(() => null), | |||
| getFeatureVariableBoolean: jest.fn(() => null), | |||
| getFeatureVariableDouble: jest.fn(() => null), | |||
| getFeatureVariableJSON: jest.fn(() => null), | |||
| getAllFeatureVariables: jest.fn(() => { return {} }), | |||
There was a problem hiding this comment.
Oh, interesting that getAllFeatureVariables was not here before. I guess it should be added, but does it affect any test?
mjc1283
dismissed
zashraf1985’s stale review
Zeeshan took over this PR as the author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented getFeatureVariableJson, getFeatureVariable and getAllFeatureVariables wrappers of JS SDK
Deprecated in Readme
Test plan
Added unit tests for getFeatureVariableJson, getFeatureVariable and getAllFeatureVariables