Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cluster validation webhook to handle names better #142

Closed
joekr opened this issue Sep 6, 2022 · 0 comments · Fixed by #143
Closed

Update cluster validation webhook to handle names better #142

joekr opened this issue Sep 6, 2022 · 0 comments · Fixed by #143
Assignees
@joekr
Labels
enhancement New feature or request

Comments

@joekr
Copy link
Member

joekr commented Sep 6, 2022

What would you like to be added:
We should handle cluster name validation in the ocicluster_webhook

Why is this needed:
If a user tries to launch a cluster with a . in the name the control plane will not come up properly leading to the cluster not coming up.
@joekr joekr added the enhancement New feature or request label Sep 6, 2022
@joekr joekr self-assigned this Sep 8, 2022
@joekr joekr mentioned this issue Sep 8, 2022
Merged
@joekr joekr closed this as completed in #143 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joekr joekr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add cluster name check for ocicluster webhook joekr/cluster-api-provider-oci
1 participant
@joekr