Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deprecation warnings after upgrading to Ginkgo 2.0 #189

Closed
joekr opened this issue Dec 5, 2022 · 0 comments · Fixed by #217
Closed

Handle deprecation warnings after upgrading to Ginkgo 2.0 #189

joekr opened this issue Dec 5, 2022 · 0 comments · Fixed by #217
Labels
enhancement New feature or request

Comments

@joekr
Copy link
Member

joekr commented Dec 5, 2022

What would you like to be added:
As a part of PR #187 Ginkgo was upgraded to 2.0. Tests are passing with deprecated feature warnings. Example: Measure nodes are no longer supported and won't be run. https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-measure

We need to make sure all deprecation warnings are resolved.

Why is this needed:
The deprecation warnings indicate the Measure tests are no longer run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to use gomega gmeasure shyamradhakrishnan/cluster-api-provider-oci
1 participant
@joekr