Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLB/LB Reconciler to support multiple NSG if applicable #259

Closed
shyamradhakrishnan opened this issue May 8, 2023 · 0 comments · Fixed by #260
Closed

Fix NLB/LB Reconciler to support multiple NSG if applicable #259

shyamradhakrishnan opened this issue May 8, 2023 · 0 comments · Fixed by #260
Labels
bug Something isn't working

Comments

@shyamradhakrishnan
Copy link
Contributor

What happened:
Currently the code only sets the last NSG - see here https://github.com/oracle/cluster-api-provider-oci/blob/main/cloud/scope/load_balancer_reconciler.go#L189

What you expected to happen:
An array of NSGs should be created and set if NSGs are applicable

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • CAPOCI version:
  • Cluster-API version (use clusterctl version):
  • Kubernetes version (use kubectl version):
  • Docker version (use docker info):
  • OS (e.g. from /etc/os-release):
@shyamradhakrishnan shyamradhakrishnan added the bug Something isn't working label May 8, 2023
@shyamradhakrishnan shyamradhakrishnan changed the title Fix NLB/LB Reconciler to support multiple NSG if applicable Fix NLB/LB Reconciler to support multiple Subnet/NSG if applicable May 8, 2023
@shyamradhakrishnan shyamradhakrishnan changed the title Fix NLB/LB Reconciler to support multiple Subnet/NSG if applicable Fix NLB/LB Reconciler to support multiple NSG if applicable May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant