minor javadoc cleanup and access modifier fixes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the visibility changes. |
| @@ -411,8 +411,8 @@ private Source() { | |||
|
|
|||
| /** | |||
| * Returns a short version of the name of the resource holding a guest language program (as | |||
| * described in @getName). For example, this could be just the name of the file, rather than a | |||
dougxc
pushed a commit
that referenced
this pull request
Apr 21, 2016
…OM/truffle:master to master * commit 'feec4a84e5157b24c01329c341c69b389ecdd065': Factor language check into guard helper method in CachedObjectAccessNode Rename LanguageCheck annotation to CanResolve Use deep copy of can-resolve node of interop DSL Add tests for @LanguageCheck annotation Extend Interop DSL and provide an @LanguageCheck annotation, which allows expressing the language check as a node
sanzinger
pushed a commit
to XiaohongGong/graal
that referenced
this pull request
Jan 7, 2020
We want to find a better way to implement array offset calculation.
The old pattern for an int array member loading is:
and x4, x3, #0xffffffff
lsl x4, x4, #2
add x4, x4, #0x10
ldr x0, [x2, x4]
And the optimized pattern is:
add x1, x2, w3, uxtw #2
ldr x0, [x1, oracle#16]
Here is a jmh unit test for int array member loading:
private final int func(int[] arr) {
int ret = 0;
for (int i=0; i < field0; i++) {
ret += arr[i];
}
return ret;
}
And the jmh performance results:
without this patch with this patch units
1173501.595 948290.420 us/op
Here are the additional issues fixed related to this patch:
1. Fix an issue in MatchProcessor, so that we can process platform specific node
as a matchable node.
2. Close this optimization for substratevm because the derived reference is not
supported yet in SVM.
mx bootstrap passes.
mx gate -o -t 'CTW:hosted' passes.
Change-Id: Ia34f2bf044ca6863be075cf000b29524ca44c42d
jerboaa
pushed a commit
to jerboaa/graal
that referenced
this pull request
Aug 27, 2024
Partial backport of [GR-48529] Use the API flag in the init hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just some javadoc cleanup and object model access modifier fixes in the implementation package.