Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for org.apache.curator:curator-*:5.4.0 #163

Closed
linghengqian opened this issue Jan 6, 2023 · 7 comments
Closed

Add support for org.apache.curator:curator-*:5.4.0 #163

linghengqian opened this issue Jan 6, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@linghengqian
Copy link
Contributor

linghengqian commented Jan 6, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

  • Add support for org.apache.curator:curator-framework:5.4.0.
  • Add support for org.apache.curator:curator-client:5.4.0.
  • Add support for org.apache.curator:curator-recipes:5.4.0.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Null.

Additional context
Add any other context or screenshots about the feature request here.

@linghengqian linghengqian added the enhancement New feature or request label Jan 6, 2023
@linghengqian
Copy link
Contributor Author

  • I'm working on this issue.

@linghengqian
Copy link
Contributor Author

linghengqian commented Jan 6, 2023

Error: Found 1 violations of @Uninterruptible usage:
method java.lang.Thread.getId() is annotated but org.apache.zookeeper.server.quorum.QuorumPeer.getId() is not
com.oracle.svm.core.util.UserError$UserException: Found 1 violations of @Uninterruptible usage:
method java.lang.Thread.getId() is annotated but org.apache.zookeeper.server.quorum.QuorumPeer.getId() is not
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.util.UserError.abort(UserError.java:73)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.code.UninterruptibleAnnotationChecker.reportViolations(UninterruptibleAnnotationChecker.java:100)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.code.UninterruptibleAnnotationChecker.checkBeforeCompilation(UninterruptibleAnnotationChecker.java:91)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.code.CompileQueue.finish(CompileQueue.java:433)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:651)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:535)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:403)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:580)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:128)
------------------------------------------------------------------------------------------------------------------------
                        3.8s (4.9% of total time) in 25 GCs | Peak RSS: 4.57GB | CPU load: 4.34
========================================================================================================================
Failed generating 'curator-client-tests' after 1m 17s.
    Error: Image build request failed with exit status 1

> Task :nativeTestCompile FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':nativeTestCompile'.
> Process 'command '/home/linghengqian/.sdkman/candidates/java/22.3.r17-grl/bin/native-image'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1m 38s
7 actionable tasks: 7 executed
  • @cnauroth I want to ask when will the next 3.8.x version release of zookeeper be?

@cnauroth
Copy link

cnauroth commented Jan 6, 2023

Hello @linghengqian . There is no set schedule for a ZooKeeper 3.8.1 release yet. If you want to express interest, then I suggest that you email dev@zookeeper.apache.org and mention that you are interested in picking up ZOOKEEPER-4460. Then, the whole Apache ZooKeeper community can coordinate.

@linghengqian
Copy link
Contributor Author

@linghengqian
Copy link
Contributor Author

linghengqian commented Feb 6, 2023

  • Both curator-client and curator-framework can control the completion of test task and nativeTest task within 20 minutes, but curator-recipes is an exception. Its unit test test task takes more than 20 minutes, which is consistent with GraalVM reachability metadata The current CI settings for the central repository conflict. Reference https://github.com/oracle/graalvm-reachability-metadata/blob/3fbec45b151420c2b8f635ff40a6598da8783e41/.github/workflows/test-changed-metadata.yml .
  • image
  • I will soon submit a PR containing GraalVM reachability metadata for curator-client and curator-framework. For the CI issue, I will raise another PR in the current warehouse later to solve the problem that the unit test execution time of curator-recipes is too long, which leads to the failure of CI.
  • image

@cnauroth
Copy link

@linghengqian , Apache ZooKeeper 3.8.1 has been released:

https://lists.apache.org/thread/x11cddjozsn000kc718r5v6kpkozj8gp

@linghengqian
Copy link
Contributor Author

@linghengqian linghengqian closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants