Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Fix #3966 set collectorUri() with URL with no port number adds port #3993

Merged
merged 1 commit into from
Mar 23, 2022
Merged

3.x: Fix #3966 set collectorUri() with URL with no port number adds port #3993

merged 1 commit into from
Mar 23, 2022

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Mar 22, 2022 •
edited
Loading

See #3966

@barchetta barchetta added the 3.x Issues for 3.x version branch label Mar 22, 2022
@barchetta barchetta self-assigned this Mar 22, 2022
@barchetta barchetta changed the title Fix #3966 set collectorUri() with URL with no port number adds port (… 3.x: Fix #3966 set collectorUri() with URL with no port number adds port Mar 22, 2022
arjav-desai
arjav-desai approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit 88357d6 into helidon-io:master Mar 23, 2022
@barchetta barchetta deleted the 3.x-trace-no-port branch July 5, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjav-desai arjav-desai arjav-desai approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@barchetta barchetta

Labels
3.x Issues for 3.x version branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @arjav-desai