-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction fixes #4564
Introduction fixes #4564
Conversation
6627b56
to
a7e021d
Compare
- "windows.adoc" | ||
- "cli.adoc" | ||
- "kubernetes.adoc" | ||
- "upgrade.adoc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is our upgrade doc going to be located?
Also I am missing SE introduction page (this change only contains MP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mitia is working on migration guides. I expect adding links to the corresponding introduction pages as part of his commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't cover SE introduction page. IMO, it doesn't need modifications.
|
||
== A Collection of Java Libraries | ||
* <<What is Helidon?, What is Helidon?>> | ||
* <<Helidon Flavors, Helidon Flavors>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 2.x documentation we never used "flavor". We used "programming model" which I prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use flavor in all presentations. Upcoming Nima will have the same programming model as MP (blocking with annotations). Using programming model as differenciator will not make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with me, please resolve comments with @barchetta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4526 |
No description provided.