Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo manual shaded jar tasks #4619

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

ljnelson
Copy link
Member

No description provided.

@ljnelson ljnelson added docs cdi CDI dependencies Pull requests that update a dependency file 3.x Issues for 3.x version branch OCI labels Jul 26, 2022
@ljnelson ljnelson self-assigned this Jul 26, 2022
arjav-desai
arjav-desai previously approved these changes Jul 26, 2022
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljnelson ljnelson marked this pull request as ready for review July 27, 2022 00:01
@ljnelson ljnelson added the P2 label Jul 27, 2022
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljnelson ljnelson merged commit 75b1efe into helidon-io:master Jul 28, 2022
@ljnelson ljnelson deleted the undo-manual-shaded-jar-tasks branch July 28, 2022 17:51
@ljnelson
Copy link
Member Author

Keep an eye on: oracle/oci-java-sdk#424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch cdi CDI dependencies Pull requests that update a dependency file docs OCI P2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants