Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Server MP final review #4676

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Aug 4, 2022

Apply changes from #4545 review

Signed-off-by: tvallin thibault.vallin@oracle.com

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin requested a review from ljamen August 4, 2022 15:01
@tvallin tvallin self-assigned this Aug 4, 2022
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - thank you.

@ljamen
Copy link
Contributor

ljamen commented Aug 4, 2022

@tvallin - is this ready for me to approve or did you need a technical review? I can approve if needed.

@tvallin
Copy link
Member Author

tvallin commented Aug 4, 2022

Sure you can approve it, there is no technical stuff involved. Thank you !

@tvallin tvallin merged commit f3044bf into helidon-io:master Aug 8, 2022
@tvallin tvallin deleted the doc_server branch August 8, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants