Updates to Helidon Common, Part 2 #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
requested review from
danielkec,
romain-grecourt,
spericas and
barchetta
tomas-langer
changed the title
Remove OptionalMatcher from config testing Common Parameters module (no refactoring to it)
tomas-langer
force-pushed
the
common-2
branch
3 times, most recently
from
05ed8a5
to
1246b90
Compare
danielkec
reviewed
Aug 15, 2022
romain-grecourt
approved these changes
Aug 15, 2022
barchetta
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update of Helidon common modules and refactors all modules that use them.
Most notable changes are in
helidon-common-http(headers)helidon-common-media- media type support including identifying media type based on file suffixes; now used in both HTTP and Config (and static content)Commits separate this into smaller batches (still quite big) of changes related to modules as I was processing them.