Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify NSGs for Mount Targets provisioned by the CCM #460

Open
robo-cap opened this issue Apr 8, 2024 · 1 comment
Open
Labels

Comments

@robo-cap
Copy link
Member

robo-cap commented Apr 8, 2024

FEATURE REQUEST

In the current implementation is not possible to set the NSG for the Mount Targets created using the OCI CCM CSI.

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: fss-dyn-storage
provisioner: fss.csi.oraclecloud.com
parameters:
  availabilityDomain: US-ASHBURN-AD-1
  mountTargetSubnetOcid: ocid1.subnet.oc1.iad.aaaaaaaa2xpk______zva
  compartmentOcid: ocid1.compartment.oc1..aaaaaaaay______t6q
  kmsKeyOcid: ocid1.key.oc1.iad.anntl______usjh
  exportPath: /FileSystem1
  exportOptions: "[{\"source\":\"0.0.0.0/0\",\"requirePrivilegedSourcePort\":false,\"access\":\"READ_WRITE\",\"identitySquash\":\"NONE\"}]"
  encryptInTransit: "true"

Versions

CCM Version: v1.28.0

Environment:

  • Kubernetes version (use kubectl version): Not relevant
  • OS (e.g. from /etc/os-release): Not relevant
  • Kernel (e.g. uname -a): Not relevant
  • Others:

What happened?

There is no annotation/attribute available to specify the NSG.
The currently supported attributes are here.

What you expect to happen?

We should support setting an NSG at MT creation considering the least privileged access.
This is something supported by the OCI API when we create the MT: https://docs.oracle.com/en-us/iaas/api/#/en/filestorage/20171215/datatypes/CreateMountTargetDetails

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?

@mrunalpagnis
Copy link
Member

ACK - related to - #459 clarified over DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants