Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File.readlines(path, chomp: true) does not chomp lines #2205

Closed
eregon opened this issue Jan 1, 2021 · 2 comments
Closed

File.readlines(path, chomp: true) does not chomp lines #2205

eregon opened this issue Jan 1, 2021 · 2 comments
Assignees
@bjfish
Labels
compatibility
Milestone
21.1.0

Comments

@eregon
Copy link
Member

eregon commented Jan 1, 2021

And instead keeps the \n as if chomp: true was not passed.

It seems MRI does not check for extra keyword arguments for File.readlines, so unfortunately we can't check strictly either.
@eregon
Copy link
Member Author

eregon commented Jan 4, 2021

@bjfish Could you fix this?

@bjfish
Copy link
Contributor

bjfish commented Jan 7, 2021

This is fixed at: 9356618

@bjfish bjfish closed this as completed Jan 7, 2021
@bjfish bjfish added this to the 21.1.0 milestone Jan 7, 2021
@zofrex zofrex mentioned this issue Apr 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjfish bjfish

Labels
compatibility
Projects
None yet
Milestone
21.1.0
Development

No branches or pull requests
2 participants
@bjfish @eregon