Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hash#rehash #2263

Closed
chrisseaton opened this issue Feb 20, 2021 · 4 comments · Fixed by #2310
Closed

Fix Hash#rehash #2263

chrisseaton opened this issue Feb 20, 2021 · 4 comments · Fixed by #2310
Assignees
@MattAlp
Labels
bug compatibility
Milestone
21.2.0

Comments

@chrisseaton
Copy link
Collaborator

Hash#rehash is tagged.

truffleruby/spec/tags/core/hash/rehash_tags.txt

Line 1 in 634c0ae

fails:Hash#rehash removes duplicate keys

@MattAlp at Shopify has already been looking at this and has found some more interesting issues not shown by the specs.
@chrisseaton
Copy link
Collaborator Author

@eregon can you assign @MattAlp?

@eregon
Copy link
Member

eregon commented Feb 21, 2021

I cannot, Matt would need to reply here, then I or you could assign (GitHub requirement).

@MattAlp
Copy link
Contributor

MattAlp commented Feb 21, 2021

Replying

@MattAlp MattAlp mentioned this issue Feb 21, 2021
Closed
@eregon eregon linked a pull request Feb 22, 2021 that will close this issue
Fix rehash functionality #2266
Closed
@chrisseaton chrisseaton mentioned this issue Apr 4, 2021
Merged
@eregon eregon linked a pull request Apr 19, 2021 that will close this issue
Fix rehash functionality #2310
Merged
@eregon
Copy link
Member

eregon commented Apr 19, 2021

Fixed by #2310

@eregon eregon closed this as completed Apr 19, 2021
@eregon eregon added this to the 21.2.0 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattAlp MattAlp

Labels
bug compatibility
Projects
None yet
Milestone
21.2.0
Development

Successfully merging a pull request may close this issue.

Fix rehash functionality Shopify/truffleruby
Fix rehash functionality MattAlp/truffleruby
3 participants
@eregon @chrisseaton @MattAlp