Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Process::Status.wait #2378

Closed
eregon opened this issue Jun 16, 2021 · 2 comments
Closed

Implement Process::Status.wait #2378

eregon opened this issue Jun 16, 2021 · 2 comments
Assignees
@bjfish
Labels
compatibility
Milestone
21.3.0

Comments

@eregon
Copy link
Member

eregon commented Jun 16, 2021

Requested by @ioquatix, to fix https://github.com/socketry/event/pull/6/checks?check_run_id=2807838780

This is a new Ruby 3 method, it's the same as Process.wait but without setting $?, so it should be fairly straightforward to add.

There are no specs currently, we should add some basic specs for it.
@bjfish
Copy link
Contributor

bjfish commented Jun 18, 2021

This has been implemented at 2b88831.

@bjfish bjfish closed this as completed Jun 18, 2021
@ioquatix
Copy link
Contributor

Thanks!!!

@eregon eregon added this to the 21.3.0 milestone Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjfish bjfish

Labels
compatibility
Projects
None yet
Milestone
21.3.0
Development

No branches or pull requests
3 participants
@ioquatix @bjfish @eregon