Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String#rindex should raise error on invalid type #2608

Closed
djberg96 opened this issue Mar 2, 2022 · 1 comment
Closed

String#rindex should raise error on invalid type #2608

djberg96 opened this issue Mar 2, 2022 · 1 comment
Assignees
@bjfish
Labels
compatibility
Milestone
22.1.0

Comments

@djberg96
Copy link
Contributor

djberg96 commented Mar 2, 2022

Ruby 3.0.2:

"hello".rindex(1) # => no implicit conversion of Integer into String (TypeError)

TruffleRuby 20.0.0.2:

"hello".rindex(1) # => nil
@bjfish bjfish self-assigned this Mar 2, 2022
@bjfish
Copy link
Contributor

bjfish commented Mar 3, 2022

This is now fixed at f4ab861.

@bjfish bjfish closed this as completed Mar 3, 2022
@bjfish bjfish added this to the 22.1.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjfish bjfish

Labels
compatibility
Projects
None yet
Milestone
22.1.0
Development

No branches or pull requests
2 participants
@djberg96 @bjfish