Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate failures in oj test suite #2701

Closed
eregon opened this issue Aug 6, 2022 · 5 comments
Closed

Investigate failures in oj test suite #2701

eregon opened this issue Aug 6, 2022 · 5 comments
Assignees
Labels

Comments

@eregon
Copy link
Member

eregon commented Aug 6, 2022

See https://github.com/ohler55/oj/pull/804/files
Some missing C API functions (like rb_ivar_foreach), some differences and some segfaults.

It might be useful to run this with managed Sulong regarding the segfaults to find the invalid memory accesses.

@eregon eregon added the cexts label Aug 6, 2022
@aardvark179
Copy link
Contributor

rb_ivar_foreach seems pretty simple, though it has some special cases in MRI for classes and modules. Implementing that allows most of those skipped specs to pass, but we get two failures and 1 error for trying to call __allocate__ on something which we don't support it on. I'll take a bit more of a look and create some issues for the problems.

@aardvark179 aardvark179 self-assigned this Aug 8, 2022
@aardvark179
Copy link
Contributor

@eregon
Copy link
Member Author

eregon commented Sep 3, 2022

Most issues with the oj gem should be fixed now with 01607d7.
We need to make a PR to oj to remove the now-unecessary skips.

@eregon eregon added this to the 22.3.0 milestone Sep 3, 2022
@eregon
Copy link
Member Author

eregon commented Sep 5, 2022

I have a branch removing most skips: ohler55/oj@develop...eregon:oj:remove_most_truffleruby_skips
I'll fix rb_struct_s_members/rb_struct_members first though.

@eregon
Copy link
Member Author

eregon commented Oct 5, 2022

Most skips are removed with ohler55/oj#817.

@eregon eregon closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants