Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0 #299

Merged
merged 2 commits into from
Jun 16, 2023
Merged

chore(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0 #299

merged 2 commits into from
Jun 16, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2023

Bumps golangci/golangci-lint-action from 3.4.0 to 3.5.0.

Release notes

Sourced from golangci/golangci-lint-action's releases.

v3.5.0

What's Changed

... (truncated)

Commits
  • 5f1fec7 build(deps-dev): bump @​typescript-eslint/parser from 5.59.6 to 5.59.7 (#758)
  • 601007b build(deps): bump @​types/node from 20.2.3 to 20.2.5 (#756)
  • d2a913e build(deps-dev): bump @​typescript-eslint/eslint-plugin from 5.59.6 to 5.59.7 ...
  • 7233bd7 build(deps-dev): bump @​typescript-eslint/eslint-plugin from 5.59.5 to 5.59.6 ...
  • 687f029 build(deps): bump @​types/node from 20.1.4 to 20.2.3 (#755)
  • f9990cd build(deps-dev): bump @​typescript-eslint/parser from 5.59.5 to 5.59.6 (#754)
  • f30aa51 build(deps-dev): bump eslint from 8.40.0 to 8.41.0 (#753)
  • 6b21f58 build(deps-dev): bump @​typescript-eslint/eslint-plugin from 5.59.2 to 5.59.5 ...
  • 535ed3a build(deps): bump @​types/semver from 7.3.13 to 7.5.0 (#748)
  • 0078ef0 build(deps-dev): bump @​typescript-eslint/parser from 5.59.1 to 5.59.5 (#750)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0
a5a0cd7 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@08e2f20...5f1fec7)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jun 5, 2023
@azrod
Copy link
Member

azrod commented Jun 8, 2023

Warning check if new version of golangci-lint not generate new lint issues

@azrod
Copy link
Member

azrod commented Jun 8, 2023 

WARN [runner] The linter 'ifshort' is deprecated (since v1.48.0) due to: The repository of the linter has been deprecated by the owner.  
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
pkg/utils/utils_test.go:43:3: `name` is unused (structcheck)
                name string
                ^
pkg/utils/utils_test.go:44:3: `args` is unused (structcheck)
                args args[T]
                ^
pkg/utils/utils_test.go:45:3: `want` is unused (structcheck)
                want types.String
                ^
pkg/utils/utils_test.go:39:3: `value` is unused (structcheck)
                value T
                ^
internal/provider/common/vm/os_type.go:4:2: `name` is unused (structcheck)
        name        string
        ^
internal/provider/common/vm/os_type.go:5:2: `description` is unused (structcheck)
        description string
        ^
internal/provider/common/mutex/mutex.go:9:2: import 'github.com/hashicorp/terraform-plugin-log/tflog' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-log/tflog"
        ^
internal/provider/common/edgegw/edgegw.go:7:2: import 'github.com/vmware/go-vcloud-director/v2/govcd' is not allowed from list 'Main' (depguard)
        "github.com/vmware/go-vcloud-director/v2/govcd"
        ^
internal/provider/common/edgegw/edgegw.go:9:2: import 'github.com/hashicorp/terraform-plugin-framework/types' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/types"
        ^
internal/provider/common/edgegw/edgegw.go:11:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client"
        ^
internal/provider/common/edgegw/edgegw.go:12:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/mutex' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/mutex"
        ^
internal/provider/common/org/edgegw.go:4:2: import 'github.com/vmware/go-vcloud-director/v2/govcd' is not allowed from list 'Main' (depguard)
        "github.com/vmware/go-vcloud-director/v2/govcd"
        ^
internal/provider/common/org/edgegw.go:6:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/edgegw' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/edgegw"
        ^
internal/provider/common/org/org.go:4:2: import 'github.com/hashicorp/terraform-plugin-framework/diag' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/diag"
        ^
internal/provider/common/org/org.go:6:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client"
        ^
internal/provider/alb/pool_common.go:6:2: import 'github.com/vmware/go-vcloud-director/v2/govcd' is not allowed from list 'Main' (depguard)
        "github.com/vmware/go-vcloud-director/v2/govcd"
        ^
internal/provider/alb/pool_common.go:7:2: import 'github.com/vmware/go-vcloud-director/v2/types/v56' is not allowed from list 'Main' (depguard)
        govcdtypes "github.com/vmware/go-vcloud-director/v2/types/v56"
        ^
internal/provider/alb/pool_common.go:9:2: import 'github.com/hashicorp/terraform-plugin-framework/types' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/types"
        ^
internal/provider/alb/pool_common.go:11:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/pkg/utils' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/pkg/utils"
        ^
internal/provider/alb/pool_datasource.go:8:2: import 'github.com/vmware/go-vcloud-director/v2/govcd' is not allowed from list 'Main' (depguard)
        "github.com/vmware/go-vcloud-director/v2/govcd"
        ^
internal/provider/alb/pool_datasource.go:10:2: import 'github.com/hashicorp/terraform-plugin-framework/diag' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/diag"
        ^
internal/provider/alb/pool_datasource.go:11:2: import 'github.com/hashicorp/terraform-plugin-framework/types' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/types"
        ^
internal/provider/alb/pool_datasource.go:13:2: import 'github.com/hashicorp/terraform-plugin-framework/datasource' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/datasource"
        ^
internal/provider/alb/pool_datasource.go:15:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client"
        ^
internal/provider/alb/pool_datasource.go:16:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/edgegw' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/edgegw"
        ^
internal/provider/alb/pool_datasource.go:17:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/org' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/org"
        ^
internal/provider/alb/pool_resource.go:10:2: import 'github.com/vmware/go-vcloud-director/v2/govcd' is not allowed from list 'Main' (depguard)
        "github.com/vmware/go-vcloud-director/v2/govcd"
        ^
internal/provider/alb/pool_resource.go:11:2: import 'github.com/vmware/go-vcloud-director/v2/types/v56' is not allowed from list 'Main' (depguard)
        govcdtypes "github.com/vmware/go-vcloud-director/v2/types/v56"
        ^
internal/provider/alb/pool_resource.go:13:2: import 'github.com/hashicorp/terraform-plugin-framework/diag' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/diag"
        ^
internal/provider/alb/pool_resource.go:14:2: import 'github.com/hashicorp/terraform-plugin-framework/path' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/path"
        ^
internal/provider/alb/pool_resource.go:15:2: import 'github.com/hashicorp/terraform-plugin-framework/types' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/types"
        ^
internal/provider/alb/pool_resource.go:16:2: import 'github.com/hashicorp/terraform-plugin-framework/types/basetypes' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/types/basetypes"
        ^
internal/provider/alb/pool_resource.go:18:2: import 'github.com/hashicorp/terraform-plugin-framework/resource' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource"
        ^
internal/provider/alb/pool_resource.go:20:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/client"
        ^
internal/provider/alb/pool_resource.go:21:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/edgegw' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/edgegw"
        ^
internal/provider/alb/pool_resource.go:22:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/org' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/provider/common/org"
        ^
internal/provider/alb/pool_resource.go:23:2: import 'github.com/orange-cloudavenue/terraform-provider-cloudavenue/pkg/utils' is not allowed from list 'Main' (depguard)
        "github.com/orange-cloudavenue/terraform-provider-cloudavenue/pkg/utils"
        ^
internal/provider/alb/pool_schema.go:4:2: import 'github.com/hashicorp/terraform-plugin-framework/attr' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/attr"
        ^
internal/provider/alb/pool_schema.go:5:2: import 'github.com/hashicorp/terraform-plugin-framework/path' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/path"
        ^
internal/provider/alb/pool_schema.go:6:2: import 'github.com/hashicorp/terraform-plugin-framework/schema/validator' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/schema/validator"
        ^
internal/provider/alb/pool_schema.go:7:2: import 'github.com/hashicorp/terraform-plugin-framework/types' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/types"
        ^
internal/provider/alb/pool_schema.go:9:2: import 'github.com/hashicorp/terraform-plugin-framework/datasource/schema' is not allowed from list 'Main' (depguard)
        schemaD "github.com/hashicorp/terraform-plugin-framework/datasource/schema"
        ^
internal/provider/alb/pool_schema.go:10:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema' is not allowed from list 'Main' (depguard)
        schemaR "github.com/hashicorp/terraform-plugin-framework/resource/schema"
        ^
internal/provider/alb/pool_schema.go:12:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
        ^
internal/provider/alb/pool_schema.go:13:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema/int64default' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource/schema/int64default"
        ^
internal/provider/alb/pool_schema.go:14:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
        ^
internal/provider/alb/pool_schema.go:15:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
        ^
internal/provider/alb/pool_schema.go:16:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
        ^
internal/provider/alb/pool_schema.go:18:2: import 'github.com/hashicorp/terraform-plugin-framework-validators/int64validator' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework-validators/int64validator"
        ^
internal/provider/alb/pool_schema.go:19:2: import 'github.com/hashicorp/terraform-plugin-framework-validators/setvalidator' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework-validators/setvalidator"
        ^
internal/provider/alb/pool_schema.go:20:2: import 'github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
        ^
internal/provider/alb/pool_schema.go:22:2: import 'github.com/FrangipaneTeam/terraform-plugin-framework-superschema' is not allowed from list 'Main' (depguard)
        superschema "github.com/FrangipaneTeam/terraform-plugin-framework-superschema"
        ^
internal/provider/alb/pool_schema.go:23:2: import 'github.com/FrangipaneTeam/terraform-plugin-framework-validators/stringvalidator' is not allowed from list 'Main' (depguard)
        fstringvalidator "github.com/FrangipaneTeam/terraform-plugin-framework-validators/stringvalidator"
        ^
internal/provider/common/storageprofile/storage_profile.go:6:2: import 'github.com/vmware/go-vcloud-director/v2/types/v56' is not allowed from list 'Main' (depguard)
        govcdtypes "github.com/vmware/go-vcloud-director/v2/types/v56"
        ^
internal/provider/common/storageprofile/storage_profile.go:8:2: import 'github.com/hashicorp/terraform-plugin-framework/schema/validator' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/schema/validator"
        ^
internal/provider/common/storageprofile/storage_profile.go:10:2: import 'github.com/hashicorp/terraform-plugin-framework/resource/schema' is not allowed from list 'Main' (depguard)
        "github.com/hashicorp/terraform-plugin-framework/resource/schema"
        ^
internal/provider/vapp/vapp_resource.go:366:4: naked return in func `updateVapp` with 100 lines of code (nakedret)
                        return
                        ^
internal/provider/vapp/vapp_resource.go:380:4: naked return in func `updateVapp` with 100 lines of code (nakedret)
                        return
                        ^
internal/provider/vapp/vapp_resource.go:385:3: naked return in func `updateVapp` with 100 lines of code (nakedret)
                return
                ^
internal/provider/vapp/vapp_resource.go:392:4: naked return in func `updateVapp` with 100 lines of code (nakedret)
                        return
                        ^
internal/provider/vapp/vapp_resource.go:411:5: naked return in func `updateVapp` with 100 lines of code (nakedret)
                                return
                                ^
internal/provider/vapp/vapp_resource.go:426:4: naked return in func `updateVapp` with 100 lines of code (nakedret)
                        return
                        ^
internal/provider/vapp/vapp_resource.go:436:5: naked return in func `updateVapp` with 100 lines of code (nakedret)
                                return
                                ^
internal/provider/vapp/vapp_resource.go:440:5: naked return in func `updateVapp` with 100 lines of code (nakedret)
                                return
                                ^
internal/provider/vapp/vapp_resource.go:446:5: naked return in func `updateVapp` with 100 lines of code (nakedret)
                                return
                                ^
internal/provider/vapp/vapp_resource.go:450:5: naked return in func `updateVapp` with 100 lines of code (nakedret)
                                return
                                ^
internal/provider/common/vm/internal_disk.go:150:3: naked return in func `InternalDiskCreate` with 70 lines of code (nakedret)
                return
                ^
internal/provider/common/vm/internal_disk.go:156:3: naked return in func `InternalDiskCreate` with 70 lines of code (nakedret)
                return
                ^
internal/provider/common/vm/internal_disk.go:172:4: naked return in func `InternalDiskCreate` with 70 lines of code (nakedret)
                        return
                        ^
internal/provider/common/vm/internal_disk.go:206:3: naked return in func `InternalDiskCreate` with 70 lines of code (nakedret)
                return
                ^
internal/provider/common/vm/internal_disk.go:252:3: naked return in func `InternalDiskUpdate` with 57 lines of code (nakedret)
                return
                ^
internal/provider/common/vm/internal_disk.go:258:3: naked return in func `InternalDiskUpdate` with 57 lines of code (nakedret)
                return
                ^
internal/provider/common/vm/internal_disk.go:264:3: naked return in func `InternalDiskUpdate` with 57 lines of code (nakedret)
                return
                ^
internal/provider/common/vm/internal_disk.go:280:4: naked return in func `InternalDiskUpdate` with 57 lines of code (nakedret)
                        return
                        ^
internal/provider/common/vm/internal_disk.go:295:3: naked return in func `InternalDiskUpdate` with 57 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:456:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:461:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:467:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:472:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:477:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:482:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:487:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:493:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:505:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:510:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^
internal/provider/vm/common_vm.go:572:3: naked return in func `createPlan` with 124 lines of code (nakedret)
                return
                ^

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2023

A newer version of golangci/golangci-lint-action exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@dmicheneau dmicheneau merged commit d6a0d9b into main Jun 16, 2023
@dmicheneau dmicheneau deleted the dependabot/github_actions/golangci/golangci-lint-action-3.5.0 branch June 16, 2023 07:57
gaetanars pushed a commit that referenced this pull request Jun 16, 2023
chore: update CHANGELOG.md for #299
d23c814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azrod @dmicheneau