Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vdc resource #31

Merged
merged 7 commits into from
Feb 10, 2023
Merged

feat: add vdc resource #31

merged 7 commits into from
Feb 10, 2023

Conversation

gaetanars
Copy link
Contributor

Description of your changes

Add VDC Ressource

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

It can not be tested because of API that respond with a strange error on creation.

Import was successfully tested.

@gaetanars gaetanars linked an issue Feb 9, 2023 that may be closed by this pull request
@crown-app
Copy link

crown-app bot commented Feb 9, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@gaetanars
Copy link
Contributor Author

/label:add category/vdc

@gaetanars gaetanars force-pushed the 18-new-resource-vcd branch from 1c2c6f6 to 841681f Compare February 9, 2023 13:42
@azrod
Copy link
Member

azrod commented Feb 9, 2023

/label:add category/helper

@crown-app crown-app bot added the Chore label Feb 9, 2023
@crown-app crown-app bot added the Fix label Feb 9, 2023
internal/provider/vdc_resource.go Outdated Show resolved Hide resolved
internal/provider/vdc_resource.go Outdated Show resolved Hide resolved
internal/provider/vdc_resource.go Outdated Show resolved Hide resolved
internal/provider/vdc_resource.go Outdated Show resolved Hide resolved
internal/provider/vdc_resource.go Outdated Show resolved Hide resolved
@gaetanars
Copy link
Contributor Author

All Terraform operations have been tested.
Only the Read function is problematic because the API don't send cpu_allocated value.

@gaetanars gaetanars requested a review from azrod February 10, 2023 09:24
@gaetanars gaetanars merged commit a857814 into main Feb 10, 2023
@gaetanars gaetanars deleted the 18-new-resource-vcd branch February 10, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: vdc
2 participants