Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error log for oras push and oras attach when annotation file is invalid #1021

Closed
qweeah opened this issue Jul 12, 2023 · 1 comment · Fixed by #1026
Closed

improve error log for oras push and oras attach when annotation file is invalid #1021

qweeah opened this issue Jul 12, 2023 · 1 comment · Fixed by #1026
Assignees
@1Shubham7
Labels
good first issue Good for newcomers logging ux User experience related
Milestone
v1.1.0

Comments

@qweeah
Copy link
Contributor

qweeah commented Jul 12, 2023 •
edited
Loading

If a malformed JSON file is provided via --annotation-file flag, oras will output below error log, which is hard to understand for the common user.

Error: json: cannot unmarshal string into Go value of type map[string]string

CLI should

  1. give hints of the provided path of JSON file is malformed, and
  2. point user to the document in https://oras.land/docs/how_to_guides/manifest_annotations.
@qweeah qweeah added good first issue Good for newcomers ux User experience related labels Jul 12, 2023
@qweeah qweeah added this to the v1.2.0 milestone Jul 12, 2023
@1Shubham7
Copy link
Contributor

@qweeah Please assign me this issue.

@1Shubham7 1Shubham7 mentioned this issue Jul 19, 2023
Merged
4 tasks
@qweeah qweeah modified the milestones: v1.2.0, v1.1.0 Aug 1, 2023
This was referenced Aug 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1Shubham7 1Shubham7

Labels
good first issue Good for newcomers logging ux User experience related
Projects
ORAS Project Board-2023
Status: Done
Milestone
v1.1.0
3 participants
@sajayantony @qweeah @1Shubham7