Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on docker CLI #414

Closed
shizhMSFT opened this issue Jun 22, 2022 · 6 comments · Fixed by #990
Closed

Remove dependency on docker CLI #414

shizhMSFT opened this issue Jun 22, 2022 · 6 comments · Fixed by #990
Labels
enhancement New feature or request
Milestone

Comments

@shizhMSFT
Copy link
Contributor

oras CLI leverage github.com/docker/cli for reading / writing docker config file for login and logout. It is possible that using an old version of oras CLI with a new version of docker CLI at the same time may cause loss on some config fields.

@FeynmanZhou
Copy link
Member

@shizhMSFT Does it mean ORAS CLI will need to implement its own authentication system?

@shizhMSFT
Copy link
Contributor Author

@shizhMSFT Does it mean ORAS CLI will need to implement its own authentication system?

No, the new implementation will still be compatible with the config.json of the docker CLI.

@shizhMSFT shizhMSFT modified the milestones: v1.0.0, future Nov 2, 2022
@shizhMSFT shizhMSFT modified the milestones: future, v1.1.0 Mar 22, 2023
@shizhMSFT
Copy link
Contributor Author

@shizhMSFT shizhMSFT added the enhancement New feature or request label Mar 22, 2023
@TerryHowe
Copy link
Member

Done?

@TerryHowe
Copy link
Member

TerryHowe commented May 31, 2023

There is an indirect dependency https://github.com/oras-project/oras/blob/main/go.mod#L19

@qweeah
Copy link
Contributor

qweeah commented Jun 5, 2023

ORAS CLI still have deps on github.com/docker/docker-credential-helpers v0.7.0. Resolving this issue is depending on oras-project/oras-credentials-go#67 and merging of oras-project/oras-credentials-go#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants