Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

password input prompt not showing if only username is provided #724

Closed
1 task done
qweeah opened this issue Dec 18, 2022 · 0 comments · Fixed by #725
Closed
1 task done

password input prompt not showing if only username is provided #724

qweeah opened this issue Dec 18, 2022 · 0 comments · Fixed by #725
Assignees
@qweeah
Labels
bug Something isn't working
Milestone
v1.0.0-rc.1

Comments

@qweeah
Copy link
Contributor

qweeah commented Dec 18, 2022 •
edited
Loading

What happened in your environment?

discover, repo ls and repo tags commands won't show input prompt, when username is provided but password is not provided.

What did you expect to happen?

If username is provided via -u/username flag and no password is provided via -p/password flag, should prompt for password input.

How can we reproduce it?

oras discover <reg>/<repo>:<tag> -u <username>
oras repo tags <reg>/<repo> -u <username>
oras repo ls <reg> -u <username>

What is the version of your ORAS CLI?

0.16.0

What is your OS environment?

Ubuntu 20.04

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah qweeah added the bug Something isn't working label Dec 18, 2022
@qweeah qweeah self-assigned this Dec 18, 2022
@qweeah qweeah added this to the v1.0.0-rc.1 milestone Dec 18, 2022
@qweeah qweeah mentioned this issue Dec 19, 2022
Merged
shizhMSFT pushed a commit that referenced this issue Dec 19, 2022
@qweeah
fix: add stdin password for discover, repo ls and repo tags (#725)
22697f9 
Resolves #724 

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe pushed a commit to TerryHowe/oras that referenced this issue Feb 2, 2023
@qweeah
fix: add stdin password for discover, repo ls and repo tags (or…
f496a13 
…as-project#725)

Resolves oras-project#724 

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

fix: add stdin password for discover, repo ls and repo tags qweeah/oras
1 participant
@qweeah