-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform flag to attach command #813
Comments
Thanks for providing this great idea. It should be added to oras so user won't need to find the digest of a certain arch by themselves. cc @FeynmanZhou |
@SamirPS I would like to understand a little bit more about your scenario. As far as I understand you would like to attach an artifact to each arch image. My assumption is that you want to build the following structure:
Is my assumption correct? |
Hello @toddysm |
Apologies - copy and paste mistake on my side :) This is possible right now although it requires a bit more elaborate steps. You should directly attach to the manifest that is for this particular architecture instead to the index manifest. You can easily get that by pulling the index manifest and getting a reference to the arch specific manifest using jq. Let me know if you need more details about how to do that. One principle we are trying to follow with ORAS to make it agnostic to the artifacts that are pushed. Using architecture in the command is very specific to container image artifact types and goes against this principle. Your request though prompts some interesting ideas for some future capabilities like the following:
It is a very rough idea, and it will need to go over more thorough design discussions because I can see quite a few issues with this right now that can go wrong. |
You talk about doing Oras attach repo:tag@digestofarm for example ? Right now I'm using it. And i understand your point of view and yeah I thinks it's will need more discussion |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Any news about this issue? |
@shizhMSFT @FeynmanZhou @sajayantony for planning |
Linking #834 |
What is the version of your ORAS CLI
Version: 1.0.0-rc.1+unreleased Go version: go1.20 Git commit: 8bda262 Git tree state: clean
What would you like to be added?
Right now, if I have a multi-arch image, I need this to attach a file to each arch.
I would like to be able to do something like this.
Why is this needed for ORAS?
Right now, I have a multi-arch image, and it will be more intuitive to attach an artefact to an arch with the platform flag, especially when we can discover and cp with the platform flag.
Are you willing to submit PRs to contribute to this feature?
The text was updated successfully, but these errors were encountered: