From ae6f28d04908cfc2253078b017442d4b64f96c97 Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Tue, 26 Dec 2023 09:36:12 +0000 Subject: [PATCH 1/4] build(ci): enforce coverage check Signed-off-by: Billy Zha --- .github/{.codecov.yml => codecov.yml} | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) rename .github/{.codecov.yml => codecov.yml} (83%) diff --git a/.github/.codecov.yml b/.github/codecov.yml similarity index 83% rename from .github/.codecov.yml rename to .github/codecov.yml index 45872bae9..b18e55612 100644 --- a/.github/.codecov.yml +++ b/.github/codecov.yml @@ -11,8 +11,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +# See docs in https://docs.codecov.com/docs/commit-status coverage: status: project: default: - target: 60% \ No newline at end of file + target: 75% + patch: + default: + target: 80% \ No newline at end of file From 146c4508e2b63be2b461419b4011fba9191a5276 Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Tue, 26 Dec 2023 10:00:40 +0000 Subject: [PATCH 2/4] remove patch Signed-off-by: Billy Zha --- .github/codecov.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/codecov.yml b/.github/codecov.yml index b18e55612..d7b0b5b44 100644 --- a/.github/codecov.yml +++ b/.github/codecov.yml @@ -16,7 +16,4 @@ coverage: status: project: default: - target: 75% - patch: - default: - target: 80% \ No newline at end of file + target: 75% \ No newline at end of file From a61653e12d8fed5c6d953c33967c9c0dd373214e Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Tue, 26 Dec 2023 12:04:54 +0000 Subject: [PATCH 3/4] add failure option Signed-off-by: Billy Zha --- .github/codecov.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/codecov.yml b/.github/codecov.yml index d7b0b5b44..bd3cf58f6 100644 --- a/.github/codecov.yml +++ b/.github/codecov.yml @@ -11,9 +11,9 @@ # See the License for the specific language governing permissions and # limitations under the License. -# See docs in https://docs.codecov.com/docs/commit-status coverage: status: project: default: - target: 75% \ No newline at end of file + target: 75% + if_ci_failed: error \ No newline at end of file From b18828283f5559401db880f6c7a0e958475c132c Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Thu, 28 Dec 2023 08:22:56 +0000 Subject: [PATCH 4/4] rename back Signed-off-by: Billy Zha --- .github/{codecov.yml => .codecov.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{codecov.yml => .codecov.yml} (100%) diff --git a/.github/codecov.yml b/.github/.codecov.yml similarity index 100% rename from .github/codecov.yml rename to .github/.codecov.yml