[utils] add parent to createTag signature

[npeltier]

a lot of createTag usages are followed by the line append like following

const child = createTag('div', attributes);
parent.append(child)

this simple proposal is to add parent attribute so we have

const child = createTag('div', attributes, null, parent);

instead, could have made a PR but i guess a discussion is better :) especially that we could consider this another utils, appendTag, with same signature as createTag, plus the parent that uses createTag underneath, but i think i prefer the first one.

[chrischrischris]

I see no problem with that as long as it's an optional param. What's the null attribute? Optional params should always have default values.

[npeltier]

i like your option, but then i guess i need to test if first arg is object or string before getting on to ensure backward compatibility, @overmyheadandbody right?

[npeltier]

what does LE: mean? :)

[npeltier]

ha ok just re-read, and i don't change original signature, but i add optional options got that :)

[overmyheadandbody]

Yep, exactly, everything stays the same, but instead of having a specific parent argument, we would have an options one, containing whatever new configuration setting we might need. In your case, a parent property.

---

LE is Later Edit, was under a bit of time crunch so that message was all over the place 😅

[npeltier]

done in #1647

[npeltier]

in future, after having looked at usages, we could:

• move attributes & html to options,
• make a createTags function that takes a more complex json for nested cases, or "just" see if more complex html shouldn't just be used in such cases

[npeltier]

@overmyheadandbody @narcis-radu can you have another look at a simpler version #1698, usage PR will come afterward

[npeltier]

commerce usage #1706