verified, trivial, and do not merge

[auniverseaway]

@overmyheadandbody wrote:

We're trying to figure out a process of how these changes could go through QA before merging. I don't think we're at a point where we can just count on automated tests to ensure nothing breaks. If you feel like this isn't the right approach, we're definitely open to some suggestions

Thanks for this. I guess our process is confusing, because you're definitely not the only one that has done this.

The absence of the verified or trivial label is exactly what you are trying to achieve with do not merge. This is why we have it in our checks (Enforce PR labels):

• If the PR has not been verified by a human, it should not be merged.
• If someone doesn't deem the PR trivial it should not be merged.

The above is covered at https://github.com/adobecom/milo/wiki/PR-Labels#labels, but we could probably do a better job there.

Based on what we saw in Dexter land, everyone should be doing E2E QA. We do not want to go back to a world where we dump our code on QEs.

Let me know your thoughts.