Should we align all boolean option name in setup bash? #4875
Owen-Liuyuxuan
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Code of Conduct
Contents
There have been some refactoring and updates here and there in the setup bash and Autoware Playbooks.
For now, some setup options are set using "y/N" while some use "true/false", which has created some chaos in deployment (though we believe it is a temporary one).
https://github.com/autowarefoundation/autoware/blame/main/setup-dev-env.sh
https://github.com/autowarefoundation/autoware/blob/main/ansible/playbooks/universe.yaml
I consider "true/false" to be better than "y/N" as a good interface for managing configuration texts/params, and "y/N" should only remain in the command line interaction instead of argument passing.
I would like to hear from the architecture team on these updates?
Beta Was this translation helpful? Give feedback.
All reactions