feat(changelog): support splitting commits by lines #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orhun please let me know if there are any code quality or reservations about merging. Perhaps it would need more warnings about how splitting commits or allowing multiple changes per commit violates the conventional commits standard? I have an intent to use the feature whether as a fork or upstreamed. |
…t is not provided
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 42.89% 44.59% +1.70%
==========================================
Files 15 15
Lines 998 1034 +36
Branches 258 265 +7
==========================================
+ Hits 428 461 +33
Misses 442 442
- Partials 128 131 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orhun
approved these changes
Aug 12, 2022
orhun
changed the title
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 21, 2022
For pin@ ## [0.9.0] - 2022-08-16 ### Documentation - Add test repository link to README.md ### Features - Support splitting commits by lines ([#101](orhun/git-cliff#101)) - Support setting commit SHA while using `--with-commit` - Add commit author and committer to the context ([#100](orhun/git-cliff#100)) ### Miscellaneous Tasks - Use an alternative method to fetch registry - Enable building arm64 docker images - Update the description on Docker Hub on push - Disable updating the description on Docker Hub - Add GitHub Sponsors option for funding - Upgrade dependencies - Update MSRV to 1.60.0 - Upgrade versions in Dockerfile - Enable strip option for release profile ### Refactor - Run clippy for tests - Use a more concise conversion for string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables splitting commits by line, representing multiple changes in a single commit.
Motivation and Context
To be upfront: this violates "conventional commits". It should remain off by default if conventional commits is to be respected.
This change makes it easier for teams to gradually adopt conventional commits with less friction and a lower barrier to entry.
This also (as a side effect, but not intended) enables squash commits to behave much more nicely when they summarize a set of changes as a unit.
How Has This Been Tested?
This is being tested on the repo https://github.com/pulumi/pulumi-watch along with a GitHub Action that scans pull request bodies to render the eventual changelog.
Screenshots / Output (if appropriate):
Types of changes
Checklist: