-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(args): update clap and clap extras to v4 #137
Conversation
Codecov ReportBase: 43.63% // Head: 43.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 43.63% 43.63%
=======================================
Files 12 12
Lines 557 557
=======================================
Hits 243 243
Misses 314 314
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi, thanks for your contribution! 🐻
Can you do a more through test with running the other commands as well? Also, can you update README.md and other parts of the codebase (if necessary) accordingly? |
Yeah sure I ran through the rest of the example commands in the readme, and they all seemed to work! I tried to keep it unchanged, from an outside perspective, so I don't think there needs to be any updates to the readme, and I think I got all the references to previous clap versions in the rest of the codebase. |
hey @orhun is there anything else you need me to do for this? |
Hello @lbowenwest, sorry I was a bit busy and couldn't review this PR. I think we're ready to go if you update |
No worries, what about the readme do you want me to update? All the options should be the same. |
I thought the new version of |
The formatting changed (color was dropped, headings got different capitalization, etc.) but since the README doesn't show full |
8bed646
to
622ccea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, TYSM! 🐻
Description
Update clap version to v4 latest, as well as clap_complete and clap_mangen to the latest versions
Motivation and Context
Closes #125
How Has This Been Tested?
Running the help and version commands locally
Screenshots / Output (if appropriate):
Types of changes
Checklist: