Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(args): update clap and clap extras to v4 #137

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

lbowenwest
Copy link
Contributor

@lbowenwest lbowenwest commented Jan 15, 2023

Description

Update clap version to v4 latest, as well as clap_complete and clap_mangen to the latest versions

Motivation and Context

Closes #125

How Has This Been Tested?

Running the help and version commands locally

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: dependency update

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lbowenwest lbowenwest requested a review from orhun as a code owner January 15, 2023 15:58
@codecov-commenter
Copy link

Codecov Report

Base: 43.63% // Head: 43.63% // No change to project coverage 👍

Coverage data is based on head (f21a28e) compared to base (336b25f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   43.63%   43.63%           
=======================================
  Files          12       12           
  Lines         557      557           
=======================================
  Hits          243      243           
  Misses        314      314           
Flag Coverage Δ
unit-tests 43.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
git-cliff/src/bin/completions.rs 0.00% <ø> (ø)
git-cliff/src/lib.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@orhun
Copy link
Owner

orhun commented Jan 16, 2023

Hi, thanks for your contribution! 🐻

How Has This Been Tested?

Running the help and version commands locally

Can you do a more through test with running the other commands as well?

Also, can you update README.md and other parts of the codebase (if necessary) accordingly?

@orhun orhun changed the title (feat): Update clap (and extras) to v4 feat(args): update clap and clap extras to v4 Jan 16, 2023
@lbowenwest
Copy link
Contributor Author

Yeah sure I ran through the rest of the example commands in the readme, and they all seemed to work!

I tried to keep it unchanged, from an outside perspective, so I don't think there needs to be any updates to the readme, and I think I got all the references to previous clap versions in the rest of the codebase.

@lbowenwest
Copy link
Contributor Author

hey @orhun is there anything else you need me to do for this?

@orhun
Copy link
Owner

orhun commented Feb 7, 2023

Hello @lbowenwest, sorry I was a bit busy and couldn't review this PR. I think we're ready to go if you update README.md as well. More specifically: https://github.com/orhun/git-cliff#command-line-arguments

@lbowenwest
Copy link
Contributor Author

No worries, what about the readme do you want me to update? All the options should be the same.

@orhun
Copy link
Owner

orhun commented Feb 7, 2023

I thought the new version of clap changed the style of the help text. If it's not, then it's all good. I will review & merge this soon if everything goes well with my tests!

@alerque
Copy link
Contributor

alerque commented Feb 7, 2023

The formatting changed (color was dropped, headings got different capitalization, etc.) but since the README doesn't show full --help output only excerpts those bits may not actually have changed.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, TYSM! 🐻

@orhun orhun merged commit 0e710c2 into orhun:main Feb 8, 2023
joshka added a commit to joshka/git-cliff that referenced this pull request Sep 23, 2023
This reverts commit 0e710c2.

This is to ensure that there is no GPL 3.0 code contributions left to
address orhun#165
@joshka joshka mentioned this pull request Sep 23, 2023
12 tasks
orhun added a commit that referenced this pull request Sep 30, 2023
This reverts commit 0e710c2.

This is to ensure that there is no GPL 3.0 code contributions left to
address #165

Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
orhun added a commit that referenced this pull request Sep 30, 2023
* revert: feat(args): update clap and clap extras to v4 (#137)

This reverts commit 0e710c2.

This is to ensure that there is no GPL 3.0 code contributions left to
address #165

* chore: update to clap 4.4.4

---------

Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update clap to v4
4 participants