Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain scopes are excluded from the conventional_commits filter #25

Closed
pataar opened this issue Oct 19, 2021 · 0 comments
Closed

Certain scopes are excluded from the conventional_commits filter #25

pataar opened this issue Oct 19, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pataar
Copy link
Contributor

pataar commented Oct 19, 2021

Describe the bug
Some conventional_commits are not marked as conventional_commits. We're using scopes with underscores and those commits are not seen as conventional. This is valid though: https://github.com/conventional-commits/parser#the-grammar

To Reproduce
Steps to reproduce the behavior:

  1. Create a new commit. For example: feat(my_feature): add the new 'my' feature
  2. See that it's not included in the changelog when the conventional_commits config setting is true.

Expected behavior
It should be added as it's a valid conventional commit message.

System (please complete the following information):

  • OS Information: not relevant
  • Project Version: 0.4.0

Additional context
Add any other context about the problem here.

I think this problem occurs in the git-conventional dependency. I also made an issue there:
crate-ci/git-conventional#17

@pataar pataar added the bug Something isn't working label Oct 19, 2021
@orhun orhun closed this as completed in 10771f4 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants