Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): use form based issue templates #529

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

favna
Copy link
Contributor

@favna favna commented Mar 3, 2024

Description

GitHub supports these fancy new forms for issue templates (sadly not pull request templates) that make raising an issue a much better user experience, lets use them 😄

If you want to see how they look, we have this new feature enabled for Sapphire so this should work: https://github.com/sapphiredev/framework/issues/new/choose

docs: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema

Motivation and Context

Creating #514 and #515 and missing the form based template I'm so used to from other places

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: GitHub metadata

Checklist:

  • My code follows the code style of this project. N.A.
  • I have updated the documentation accordingly. N.A.
  • I have formatted the code with rustfmt. N.A.
  • I checked the lints with clippy. N.A.
  • I have added tests to cover my changes. N.A.
  • All new and existing tests passed. N.A.

@favna favna requested a review from orhun as a code owner March 3, 2024 22:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.14%. Comparing base (d768962) to head (1e3ef33).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   41.14%   41.14%           
=======================================
  Files          15       15           
  Lines        1038     1038           
=======================================
  Hits          427      427           
  Misses        611      611           
Flag Coverage Δ
unit-tests 41.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orhun orhun changed the title chore: github form based issue templates chore(github): use form based issue templates Mar 4, 2024
@orhun orhun merged commit 8f8e221 into orhun:main Mar 4, 2024
44 checks passed
@favna favna deleted the chore/github-form-based-issue-templates branch March 4, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants