Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): drop extra '(' in first commit URL in github-keepachangelog #535

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

dupuy
Copy link
Contributor

@dupuy dupuy commented Mar 5, 2024

Description

Remove an extra open parenthesis from the PR URL for a new committer.

Motivation and Context

The extra open parenthesis breaks the URL so that it is not properly rendered.

How Has This Been Tested?

After modifying this in my copy of the example configuration, it generates valid URLs
for new contributors.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other [example configuration]

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dupuy dupuy requested a review from orhun as a code owner March 5, 2024 14:45
Copy link

welcome bot commented Mar 5, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.14%. Comparing base (9722784) to head (4ecbf97).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   41.14%   41.14%           
=======================================
  Files          15       15           
  Lines        1038     1038           
=======================================
  Hits          427      427           
  Misses        611      611           
Flag Coverage Δ
unit-tests 41.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@orhun orhun merged commit 8b3d09f into orhun:main Mar 5, 2024
44 checks passed
Copy link

welcome bot commented Mar 5, 2024

Congrats on merging your first pull request! ⛰️

@dupuy dupuy deleted the patch-1 branch March 5, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants