Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): unify serde and serde_derive using derive feature #57

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

tranzystorekk
Copy link
Contributor

Description

Makes serde usage more unified across the project thanks to the derive feature

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tranzystorekk tranzystorekk requested a review from orhun as a code owner January 31, 2022 20:25
@codecov-commenter
Copy link

Codecov Report

Merging #57 (1543161) into main (848d8a5) will increase coverage by 0.26%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   41.14%   41.39%   +0.26%     
==========================================
  Files          13       13              
  Lines         812      807       -5     
  Branches      210      210              
==========================================
  Hits          334      334              
+ Misses        371      364       -7     
- Partials      107      109       +2     
Impacted Files Coverage Δ
git-cliff-core/src/config.rs 24.45% <0.00%> (ø)
git-cliff-core/src/release.rs 14.29% <0.00%> (-10.71%) ⬇️
git-cliff-core/src/commit.rs 72.90% <50.00%> (ø)
git-cliff-core/src/repo.rs 29.17% <0.00%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848d8a5...1543161. Read the comment docs.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking, thanks! 🐻

@orhun orhun changed the title refactor: unify serde and serde_derive under the derive feature refactor(lib): unify serde and serde_derive using derive feature Jan 31, 2022
@orhun orhun merged commit bedabc9 into orhun:main Jan 31, 2022
@tranzystorekk tranzystorekk deleted the serde-derive branch January 31, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants