-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changelog, config)!: replace --topo-order by --date-order #58
feat(changelog, config)!: replace --topo-order by --date-order #58
Conversation
@orhun I've submitted a draft PR to check tests. |
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 40.90% 41.02% +0.13%
==========================================
Files 13 13
Lines 824 824
Branches 215 216 +1
==========================================
+ Hits 337 338 +1
+ Misses 378 375 -3
- Partials 109 111 +2
Continue to review full report at Codecov.
|
It seems there were no tests that compare |
Yeah, I made that change so that workflow will complete faster. Compiling takes time...
Yup, now I see that we can revert it. I wonder if there is a way to make this run faster though. (totally out of scope of this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nitpicks here and there but overall it looks good 👍🏼 Good job with the fixtures.
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
This reverts commit 8028815.
This reverts commit 3d334cc.
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Description
Resolves #54
As explained in #54 (comment), I replaced
--topo-order
by--date-order
, which means the default value will bedate_order=false (topo_order=true)
.Motivation and Context
How Has This Been Tested?
The test script in #54 (comment) worked correctly.
Screenshots / Output (if appropriate):
output
Types of changes
Checklist: