-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): don't check last commit #619
Conversation
unreachable!() | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this check. I'm sure that the ability to parse a commit to conventional is well tested elsewhere.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 41.52% 41.52%
=======================================
Files 15 15
Lines 1072 1072
=======================================
Hits 445 445
Misses 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I just noticed that this would not change the general behaviour but it only affects your test... |
Description
Don't check if last commit is conventional.
Motivation and Context
Having the PR checks failing because one of the commits is not conventional is annoying for contributors. Original feedback: #613 (comment)
How Has This Been Tested?
I pushed fc58c87 to this PR. It's not a conventional commit and the tests still work.
Screenshots / Logs (if applicable)
Types of Changes
Checklist: