-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make include/exclude paths processing faster #640
Comments
Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️ |
Thanks for the report! I'm guessing it is due to making a lot of |
Right that's one way to do it. I wonder if the library that is used to get the git commits already has a way to handle include/exclude paths using git's own built in capability e.g.
|
It is probably a good idea to check out |
I think this should be now solved after #772 |
Is there an existing issue for this?
Description of the bug
adding include/exclude paths results in a huge slow down.
Steps To Reproduce
include-path
I observed a huge slowdown generating a changelog for a large commit range and was able to track down the slowness to this block https://github.com/orhun/git-cliff/blob/main/git-cliff-core/src/repo.rs#L63-L91. removing the
--include-path
option confirmed the cause.Expected behavior
Don't be slow? :)
Screenshots / Logs
No response
Software information
Repeatable on osx m1 and linux. does not seem to be os specific.
Additional context
No response
The text was updated successfully, but these errors were encountered: