-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bump): support setting the initial_tag
#701
Conversation
….0` when using `bump` and no tags are found Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 36.89% 36.80% -0.09%
==========================================
Files 18 18
Lines 1350 1359 +9
==========================================
+ Hits 498 500 +2
- Misses 852 859 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Wouldn't it make more sense to use the # sets the tag to 1.0.0 if no tags are found
$ git cliff --bump --tag 1.0.0 This also aligns with the current use case: # sets the unreleased changes to 1.0.0
$ git cliff --unreleased --tag 1.0.0 |
This reverts commit 1499e40. Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you fix the conflicts?
This reverts commit 02717ef. Signed-off-by: Bukowa <gitbukowa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
initial_tag
to bump
initial_tag
Description
When using
bump
and no tags are found we can modify default hardcoded0.1.0
Motivation and Context
When using tags like
package-name-v0.0.0
I would like proper initial version.How Has This Been Tested?
Fixtures included.
Screenshots / Logs (if applicable)
Types of Changes
Checklist: