Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fixture): support running fixtures on mingw64 #708

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

bukowa
Copy link
Contributor

@bukowa bukowa commented Jun 15, 2024

Description

Fixes #705

Motivation and Context

See issue.

How Has This Been Tested?

Locally.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Bukowa <gitbukowa@gmail.com>
@bukowa bukowa requested a review from orhun as a code owner June 15, 2024 18:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.22%. Comparing base (bea4916) to head (c23201e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   36.22%   36.22%           
=======================================
  Files          19       19           
  Lines        1455     1455           
=======================================
  Hits          527      527           
  Misses        928      928           
Flag Coverage Δ
unit-tests 36.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orhun orhun changed the title fix: fixture test can run on mingw64 fix(fixture): support running fixtures on mingw64 Jun 15, 2024
@orhun orhun merged commit dabe716 into orhun:main Jun 15, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixture test script not working on Windows (MINGW64)
3 participants