Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote): avoid setting multiple remotes #885

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(remote): avoid setting multiple remotes #885

merged 1 commit into from
Sep 25, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Sep 25, 2024

Motivation and Context

Fixes orhun/git-cliff-action#39 and potentially #863

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 40.04%. Comparing base (a5786be) to head (f77c1d3).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 22 Missing ⚠️
git-cliff-core/src/config.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
+ Coverage   39.97%   40.04%   +0.08%     
==========================================
  Files          21       21              
  Lines        1674     1671       -3     
==========================================
  Hits          669      669              
+ Misses       1005     1002       -3     
Flag Coverage Δ
unit-tests 40.04% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit a344c68 into main Sep 25, 2024
63 checks passed
@orhun orhun deleted the fix/remote_set branch September 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong remote type detection
2 participants