Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(repo): expand unit tests of the repo module #909

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

gsquire
Copy link
Contributor

@gsquire gsquire commented Oct 8, 2024

Description

This is a small change to get my feet wet and add some unit tests.

Motivation and Context

See #658.

How Has This Been Tested?

Unit tests.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other (unit tests)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gsquire gsquire requested a review from orhun as a code owner October 8, 2024 20:14
Copy link

welcome bot commented Oct 8, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.51%. Comparing base (e936ed5) to head (a507f9f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   40.85%   41.51%   +0.66%     
==========================================
  Files          21       21              
  Lines        1677     1677              
==========================================
+ Hits          685      696      +11     
+ Misses        992      981      -11     
Flag Coverage Δ
unit-tests 41.51% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ain't sayin no to some new unit tests 😄

Thanks!

@orhun orhun merged commit da1cb61 into orhun:main Oct 9, 2024
61 of 63 checks passed
@orhun orhun changed the title Unit Test Additions test(repo): expand unit tests of the repo module Oct 9, 2024
Copy link

welcome bot commented Oct 9, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants